Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

[5.8]When use stack driver, Processor set in custom log driver is not used #1735

Closed
sh-ogawa opened this issue Jul 24, 2019 · 3 comments
Closed

Comments

@sh-ogawa
Copy link

I confirmed createStackDriver, Using a custom log driver with the stack driver felt very difficult to implement Monolog.

So why not put the following sentence in the manual?

"At present, advanced Monolog customization is not available for the stack driver. For example, you can not pass Processor."

@mfn
Copy link

mfn commented Jul 24, 2019

Isn't that what the custom driver is for?

https://laravel.com/docs/5.8/logging#creating-channels-via-factories

@sh-ogawa
Copy link
Author

I think so, too.
However, the stack driver is implemented in the logger handler loop.
The processor specification depends on the implementation of the log driver, and I thought it would be too wild to apply to all the log channels specified in the stack driver.
Now that you feel that the stack driver extension is a high-impact repair, would you like to announce it? I suggested that.

https://github.com/laravel/framework/blob/5.8/src/Illuminate/Log/LogManager.php#L214-L225

@DominikStyp
Copy link

If anyone is still interested in fixing this issue: laravel/framework#36591

taylorotwell pushed a commit to laravel/framework that referenced this issue Mar 15, 2021
taylorotwell pushed a commit to illuminate/log that referenced this issue Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants