-
Notifications
You must be signed in to change notification settings - Fork 778
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
18e33ab
commit 0d9a007
Showing
2 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d9a007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hiya @driesvints,
This change was probably intended, but it did break a bit for me for a minor patch so wanted to run it by you.
We locked a specific Laravel version but not Passport, so moving up Passport to latest Passport broke as the minimum requirement for Passport is now 6.10+ or 7.0+, since the PSR Factory changes only occurred in 6.10 - laravel/framework#31018, but I was stupidly locked on an old Laravel 6 version.
Okay, so easy. Update Laravel and Passport together (6 latest and Passport 8 latest), until I ran into another issue. Passport removed the DiactorosFactory by upgrading to symfony/psr-http-message-bridge (2.0) https://github.com/symfony/psr-http-message-bridge/blob/master/CHANGELOG.md#200-2020-01-02 under the hood. This affected some my code and other 3rd party dependencies.
It was the only change, so the upgrade was just to remove deprecated stuff (If I'm understanding correctly) as part of this commit.
So in the release notes for Laravel 7 there were major package upgrades for affected projects. Shouldn't Passport have bumped to 9.x with this change in it? That way 8.x would have remained on the older psr message bridge.