Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that properties grant_types and scopes exist #1722

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

uintaam
Copy link
Contributor

@uintaam uintaam commented Feb 29, 2024

Calling isset on a property that doesn't exist triggers strict mode violations. We should check that the attribute isset exists instead.

@uintaam uintaam changed the title Check that property exists Check that property grant_types exists Feb 29, 2024
@crynobone
Copy link
Member

Test are failing, marking this as draft.

@crynobone crynobone marked this pull request as draft February 29, 2024 03:05
@uintaam
Copy link
Contributor Author

uintaam commented Feb 29, 2024

Thanks just fixed the tests.

@uintaam uintaam marked this pull request as ready for review February 29, 2024 03:07
@uintaam uintaam changed the title Check that property grant_types exists Check that properties grant_types and scopes exist Feb 29, 2024
@taylorotwell taylorotwell merged commit a56f7dd into laravel:11.x Feb 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants