Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable self_static_accessor fixer #154

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Mar 16, 2023

@taylorotwell
Copy link
Member

Will await @nunomaduro's feedback here.

I don't have a strong preference either way. I could see the argument for using static even if the class is final just in case the final is removed at some point.

@taylorotwell taylorotwell merged commit 7927ff1 into laravel:main Mar 17, 2023
@localheinz localheinz deleted the feature/self-static-accessor branch March 17, 2023 15:30
@localheinz
Copy link
Contributor Author

Thank you, @nunomaduro and @taylorotwell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants