Thread Subscriptions #320
Thread Subscriptions #320
Conversation
driesvints
force-pushed
the
subscriptions
branch
from
0e8270c
to
0bfe217
Compare
|
@driesvints As another use case, maybe subscribe users that comment to the thread? |
|
@m1guelpf yeah that's the idea. It's not very clear in the user stories above, that's true. I'll update it soon. |
|
@m1guelpf moved the user stories to the issue and added some more to clarify the replying. |
driesvints
force-pushed
the
subscriptions
branch
from
0bfe217
to
bc65ae3
Compare
driesvints
force-pushed
the
subscriptions
branch
3 times, most recently
from
cda5c16
to
307b66f
Compare
|
hey @driesvints i am currently hunting for open source laravel project in order to boost my knowledge and see good practices, and so far i can say that this is the first project that i found with tests 🎉 . I don't know if its the write place to write or not but forgive me if its not. I reviewed most of the code and i see you are using command/jobs pattern and i was wondering why you chose it? Cheers! |
|
@BobbyBorisov heya, no problem! I already answered that question in an issue so I'm going to link to that: #244 Hope that explains 🙂 |
driesvints
force-pushed
the
subscriptions
branch
2 times, most recently
from
b77eaab
to
a4cf01b
Compare
This will allow us to easily use mocked data in our tests.
Also refactor the internals of subscriptions to an interface and move some of the logic.
driesvints
force-pushed
the
subscriptions
branch
from
a4cf01b
to
9057fb8
Compare
To be in line with the NewReplyEmail.
driesvints
force-pushed
the
subscriptions
branch
from
9057fb8
to
d5f605b
Compare
Implementation for #270. This is all still very much WIP.
Can later on perhaps be used in #290 and #310.