Decline articles #716
Merged
Decline articles #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joedixon
requested changes
Nov 2, 2021
There was a problem hiding this comment.
Hi @tomhatzer, thank you very much for the contribution.
This mostly looks great, but I don't think we need the ability to undecline an article. Once it has been declined, it's typically because we don't fing the content to be appropriate.
Would it be possible to remove this functionality and I'll then review again. Thanks!
|
Hey @joedixon , I've just removed the undecline functionality. Looking forward to your review 😃 Thank you! |
driesvints
reviewed
Nov 3, 2021
driesvints
requested changes
Nov 3, 2021
database/migrations/2021_10_31_143501_add_declined_at_column_to_articles_table.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Dries Vints <dries@vints.io>
…rning article in DeclineArticle handle method
|
Thanks for the review @driesvints, all changes have been implemented. |
driesvints
reviewed
Nov 3, 2021
database/migrations/2021_10_31_143501_add_declined_at_column_to_articles_table.php
Show resolved
Hide resolved
joedixon
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Looks good to me. I've been looking forward to this being built so thank you @tomhatzer
|
Thanks @tomhatzer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This fixes #580 and adds decline and undecline functionality to the articles. It adds a new nullable column to the articles table named
declined_at.Feel free to comment if you have any recommendations or if there's something missing.
Have a great day! 😃