fix article control buttons #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this. Can we make all buttons like this? Also pin and delete. I also think we need different icons for publish and decline. Maybe these two? Approve: https://blade-ui-kit.com/blade-icons/heroicon-s-check |
joedixon
requested changes
Nov 12, 2021
|
@driesvints I'm happy with this when you are |
|
Thanks @faissaloux! |
|
I just noticed this PR causes a weird issue with buttons expanding on the bottom padding when you hover over them. Can we get that fixed? |
|
Yes @driesvints I just noticed the same issue I'll fix it |
|
@driesvints #732 fixes this height issue |
|
@faissaloux I just noticed that I can't seem to click any of the buttons anymore in Safari after this. |
|
@driesvints fixed here #747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #728
2021-11-09.00-25-36.mp4