Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New reply email cta #738

Merged
merged 3 commits into from
Nov 21, 2021
Merged

New reply email cta #738

merged 3 commits into from
Nov 21, 2021

Conversation

faissaloux
Copy link
Contributor

resolves #735

Screenshot from 2021-11-14 13-45-41

joedixon
joedixon requested changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@joedixon joedixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but think we could benefit from a test to show it works as intended.

resources/views/emails/new_reply.blade.php Outdated Show resolved Hide resolved
@driesvints driesvints self-assigned this Nov 19, 2021
@driesvints driesvints merged commit e711d3d into laravelio:main Nov 21, 2021
@driesvints
Copy link
Member

Thanks @faissaloux!

@faissaloux faissaloux deleted the new-reply-email-cta branch November 21, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joedixon joedixon joedixon requested changes

Assignees

@driesvints driesvints

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTA on new reply email to mark answer as solution
3 participants
@faissaloux @driesvints @joedixon