Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log queries from sqlx::query #275

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Conversation

shssoichiro
Copy link
Contributor

This will make logged queries show
as from sqlx::query instead of sqlx::db_name::executor.

Followup to #268 comment

This will make logged queries show
as from `sqlx::query` instead of `sqlx::db_name::executor`.

Followup to launchbadge#268
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual changes look fine to me, just wanted to address the magic number for the warning threshold.

sqlx-core/src/logging.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@abonander abonander merged commit 581bcf0 into launchbadge:master Apr 23, 2020
@shssoichiro shssoichiro deleted the log-path branch April 24, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants