Skip to content

Commit

Permalink
Additional comments from PR review.
Browse files Browse the repository at this point in the history
  • Loading branch information
kinyoklion committed Oct 15, 2024
1 parent 7ffe8e5 commit a0567a4
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion packages/shared/sdk-server/src/evaluation/Evaluator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ export default class Evaluator {
* @param state The current evaluation state.
* @param visitedFlags The flags that have been visited during this evaluation.
* This is not part of the state, because it needs to be forked during prerequisite evaluations.
* @param topLevel True when this function is being called in the direct evaluation of a flag,
* versus the evaluataion of a prerequisite.
*/
private _evaluateInternal(
flag: Flag,
Expand Down Expand Up @@ -217,6 +219,8 @@ export default class Evaluator {
* @param cb A callback which is executed when prerequisite checks are complete it is called with
* an {@link EvalResult} containing an error result or `undefined` if the prerequisites
* are met.
* @param topLevel True when this function is being called in the direct evaluation of a flag,
* versus the evaluataion of a prerequisite.
*/
private _checkPrerequisites(
flag: Flag,
Expand Down Expand Up @@ -287,7 +291,7 @@ export default class Evaluator {
}
return iterCb(true);
},
false,
false, // topLevel false evaluating the prerequisite.
eventFactory,
);
});
Expand Down

0 comments on commit a0567a4

Please sign in to comment.