-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Increment version for changing flagValues (#317)
When using FileData you have the option of just providing values. The pre-typescript SDK was liberal with what it considered an update and it would emit updates as things changed. Some improvements to prevent spurious update events were added in typscript and these interfered with the basic way the FileData implementation works. This PR makes a couple updates: 1.) If the value of a "flagValue" changes, then we will increment the version associated with it. 2.) If the value of a "flagValue" does not change, then we will not increment the version. This should mean when values change the version will change. Standard flag/segment JSON must update their versions manually. This will add some performance overhead. This addresses #310
- Loading branch information
1 parent
4371870
commit e8e07ef
Showing
2 changed files
with
106 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters