feat: add telemetry #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Jan 23, 2023
frontend/src/index.tsx
Outdated
Comment on lines
21
to
32
| ReactDOM.render( | ||
| <React.StrictMode> | ||
| <QueryClientProvider client={queryClient}> | ||
| <HashRouter> | ||
| <CommonParamsProvider> | ||
| <App /> | ||
| </CommonParamsProvider> | ||
| </HashRouter> | ||
| </QueryClientProvider> | ||
| </React.StrictMode>, | ||
| document.getElementById("root") | ||
| <React.StrictMode> | ||
| <QueryClientProvider client={queryClient}> | ||
| <HashRouter> | ||
| <CommonParamsProvider> | ||
| <App /> | ||
| </CommonParamsProvider> | ||
| </HashRouter> | ||
| </QueryClientProvider> | ||
| </React.StrictMode>, | ||
| document.getElementById('root'), | ||
| ); |
There was a problem hiding this comment.
oops. will revert
There was a problem hiding this comment.
this was caused by the pre-commit hook which hasn't been run on existing code.
SgtPooki
commented
Jan 23, 2023
frontend/tsconfig.json
Outdated
Comment on lines
2
to
21
| "compilerOptions": { | ||
| "baseUrl": "./src", | ||
| "target": "es5", | ||
| "lib": ["dom", "dom.iterable", "esnext"], | ||
| "allowJs": true, | ||
| "skipLibCheck": true, | ||
| "esModuleInterop": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "strict": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "module": "esnext", | ||
| "moduleResolution": "nodenext", | ||
| "resolveJsonModule": true, | ||
| "isolatedModules": true, | ||
| "noEmit": true, | ||
| "jsx": "react-jsx" | ||
| }, | ||
| "include": ["src"] | ||
| } |
There was a problem hiding this comment.
will revert. my bad
There was a problem hiding this comment.
this was caused by the pre-commit hook which hasn't been run on existing code.
had to disable pre-commit hooks which change styles to keep my diff appropriate.
SgtPooki
force-pushed
the
feat/add-telemetry
branch
from
22873f1
to
d40917a
Compare
0xDanomite
approved these changes
Jan 25, 2023
|
@laurentsenta when will this be deployed once merged |
laurentsenta
approved these changes
Jan 25, 2023
|
@SgtPooki should be instant, this was hooked into a fleek project. Feel free to merge whenever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10