Restore invalid signature behavior

lbc-team · Mar 31, 2021 · 42cafdd · 42cafdd
1 parent 3010aff
commit 42cafdd
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/hardhat-core/src/internal/hardhat-network/provider/TxPool.ts b/packages/hardhat-core/src/internal/hardhat-network/provider/TxPool.ts
@@ -253,7 +253,7 @@ export class TxPool {
     try {
       return tx.getSenderAddress(); // verifies signature
     } catch (e) {
-      throw new InvalidInputError(e.message);
+      throw new InvalidInputError("Invalid Signature");
     }
   }
 

diff --git a/packages/hardhat-core/src/internal/hardhat-network/provider/node.ts b/packages/hardhat-core/src/internal/hardhat-network/provider/node.ts
@@ -946,7 +946,7 @@ export class HardhatNode extends EventEmitter {
     try {
       sender = tx.getSenderAddress(); // verifies signature as a side effect
     } catch (e) {
-      throw new InvalidInputError(e.message);
+      throw new InvalidInputError("Invalid Signature");
     }
 
     const senderNonce = await this._txPool.getExecutableNonce(sender);

diff --git a/packages/hardhat-core/test/internal/hardhat-network/provider/TxPool.ts b/packages/hardhat-core/test/internal/hardhat-network/provider/TxPool.ts
@@ -436,7 +436,7 @@ describe("Tx Pool", () => {
         await assert.isRejected(
           txPool.addTransaction(tx),
           InvalidInputError,
-          "This transaction is not signed"
+          "Invalid Signature"
         );
       });
 

diff --git a/packages/hardhat-core/test/internal/hardhat-network/provider/modules/eth.ts b/packages/hardhat-core/test/internal/hardhat-network/provider/modules/eth.ts
@@ -3543,7 +3543,7 @@ describe("Eth module", function () {
               "0xf3808501dcd6500083015f9080800082011a80a00dbd1a45b7823be518540ca77afb7178a470b8054281530a6cdfd0ad3328cf96",
             ],
             // A missing `r` is now treated as unsigned, via the BaseTransaction method "isSigned"
-            "This transaction is not signed"
+            "Invalid Signature"
           );
         });