Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation error and word-usage error in LPython error message #2493

Open
rebcabin opened this issue Feb 6, 2024 · 4 comments
Open

Punctuation error and word-usage error in LPython error message #2493

rebcabin opened this issue Feb 6, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@rebcabin
Copy link
Contributor

rebcabin commented Feb 6, 2024

(lp) ┌─(~/Documents/GitHub/lpython/integration_tests)────(brian@MacBook-Pro:s001)─┐
└─(12:16:55 on vector-backend ✹ ✭)──> lpython ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py                                              2 ↵ ──(Tue,Feb06)─┘
semantic error: Only those local variables which can be reduced to compile time constant should be used in dimensions of an array.
  --> ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py:18:15
   |
18 |     A_nm: i16[n, m] = empty((n, m), dtype=int16)
   |               ^ 

"compile time" must be hyphenated: "compile-time" (reference: Grammarly.com plugin or Gregg Reference Manual, any edition, chapter 8).

(lp) ┌─(~/Documents/GitHub/lpython/integration_tests)────(brian@MacBook-Pro:s001)─┐
└─(12:16:55 on vector-backend ✹ ✭)──> lpython ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py                                              2 ↵ ──(Tue,Feb06)─┘
semantic error: Only those local variables which can be reduced to compile-time constant should be used in dimensions of an array.
  --> ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py:18:15
   |
18 |     A_nm: i16[n, m] = empty((n, m), dtype=int16)
   |               ^ 

also, "which can" must be "that can" in American English (reference: Grammarly.com plugin)

(lp) ┌─(~/Documents/GitHub/lpython/integration_tests)────(brian@MacBook-Pro:s001)─┐
└─(12:16:55 on vector-backend ✹ ✭)──> lpython ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py                                              2 ↵ ──(Tue,Feb06)─┘
semantic error: Only those local variables that can be reduced to compile-time constant should be used in dimensions of an array.
  --> ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py:18:15
   |
18 |     A_nm: i16[n, m] = empty((n, m), dtype=int16)
   |               ^ 
@rebcabin
Copy link
Contributor Author

rebcabin commented Feb 6, 2024

Another one (Grammarly missed this!)

"constant" should be plural "constants"

Only those local variables that can be reduced to compile-time constants should be used in dimensions of an array.

@anutosh491 anutosh491 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Feb 7, 2024
@rudhrabehara
Copy link

worked on it and opened a PR

@rudhrabehara
Copy link

please review and give suggestions

@kmr-srbh
Copy link
Contributor

@Shaikh-Ubaid This issue can be closed with reference to the above merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants