ASR: String to List Conversion #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, Thank you! x = list()
x = list([])
x = list("lpython") |
|
Will this work for runtime string variables? |
|
I will add the LLVM backend as a follow-up for runtime values. |
czgdp1807
requested changes
Sep 5, 2022
Smit-create
force-pushed
the
strtolist
branch
from
0febd0b
to
f71887e
Compare
Smit-create
force-pushed
the
strtolist
branch
from
f71887e
to
764d337
Compare
czgdp1807
approved these changes
Sep 5, 2022
| x = list("L") | ||
| assert len(x) == 1 and x[0] == 'L' | ||
|
|
||
| f() |
There was a problem hiding this comment.
This is okay. Really surprising though. None of the variables (s, x) are marked as constant but still they work with only the compile time logic you have added.
There was a problem hiding this comment.
That is because if we have a string value at compile time then we can directly make a list constant out of it. So no cast, in that case, is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#733