Generate data only array members if they are of fixed size #1388
Conversation
integration_tests/CMakeLists.txt
Outdated
| @@ -351,7 +351,8 @@ RUN(NAME structs_11 LABELS cpython llvm c) | |||
| RUN(NAME structs_12 LABELS cpython llvm c) | |||
| RUN(NAME structs_13 LABELS llvm c | |||
| EXTRAFILES structs_13b.c) | |||
| RUN(NAME structs_14 LABELS cpython llvm c) | |||
| RUN(NAME structs_14 LABELS llvm c | |||
| EXTRAFILES structs_14b.c) | |||
There was a problem hiding this comment.
We might need to do a separate test, since we lost CPython test here. We want to ideally test everything via CPython, but at least what we were testing before.
integration_tests/structs_14b.c
Outdated
| sum_buffer += data[i]; | ||
| } | ||
| return sum_buffer; | ||
| } |
There was a problem hiding this comment.
I think this is not enough. I think we need to pass the whole structure into C, then in C recreate the same structure using char[64] style, and then access the members and check that everything works. That would be robust.
The current test could still pass even with our pointer setup (yes, the memory would not be initialized properly, but one could get "lucky").
There was a problem hiding this comment.
Which one do you want to pass to C, buffer_struct (not decorated with @ccall/@ccallable) or buffer_struct_clink (decorated with @ccall/@ccallable)? I guess buffer_struct_clink should be passed to C for testing as its the one with BindC ABI, correct? If you want to pass both, then LLVM backend will also need to be updated to always (irrespective of the ABI) represent fixed sized array members as data only pointers
There was a problem hiding this comment.
I added test as per my understanding of the requirement. Please let me know if they look good or if you want any change in it. Thanks.
…d sized array members of BindC structs
czgdp1807
force-pushed
the
arr_struct_2
branch
from
407c7f7
to
08f4940
Compare
cc: @certik
Closes #1387