C: Support generics #1455
C: Support generics #1455
Conversation
| @@ -516,6 +516,9 @@ class ASRToCVisitor : public BaseCCPPVisitor<ASRToCVisitor> | |||
| sub = format_type_c("", "const " + const_underlying_type + " ", | |||
| v.m_name, false, false); | |||
| } | |||
| } else if (ASR::is_a<ASR::TypeParameter_t>(*v_m_type)) { | |||
There was a problem hiding this comment.
If I am not wrong backend shouldn't need to care if there are any generics in the frontend? The code for each type combination should be generated by the instantiate_template pass? Correct @certik?
There was a problem hiding this comment.
Yes, everything should be already instantiated, so the generics should work in all backends, no special logic needed.
There was a problem hiding this comment.
So this PR should never have been needed. @Smit-create Can you check what's there in ASR which is causing you to handle generics in C backend? I guess ASR is not correct that's why you created this PR for C backend.
There was a problem hiding this comment.
Opened an issue for it's discussion: #1471
There was a problem hiding this comment.
As per the discussion in #1471, the current ASR is fine and this diff fixes the codegen of generics in C backend.
|
Converted to a Draft for now. |
Smit-create
force-pushed
the
c_generics
branch
from
4a2c8e4
to
a0fc29d
Compare
No description provided.