-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built-in sum()
#1547
Add built-in sum()
#1547
Conversation
@Thirumalai-Shaktivel Made this pr from my |
I had experienced this previously. Probably some issue at GitHub's end. I think just pushing again (after resolving conflicts and rebasing on latest main) would run the CI tests. |
Sure, Or if you are aware of how to fetch a branch, I would like to restore it in my windows and then push from there. Thanks! |
Yes, try it.
I (usually) follow these steps to pull branches.
|
I pushed a minor tweak ,still no luck. I'll try closing and reopening to make the tests again. |
Please also resolve the conflicts and then let's see if the CI runs. |
The CI tests now run. @faze-geek I think your local main branch is not updated. The commits just before your commits were around git checkout main
git pull --rebase
// now checkout your branch and rebase over main
git checkout sum
git rebase main I just did the above and the tests ran. (I also had removed any changes in the test folder). |
Yup. If there are conflicts with the main branch, the actions (CI) don't run by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @Shaikh-Ubaid for the help and others for going through the pr. The motivation for this pr was that I'm interested in the |
sum()
is a useful inbuilt function in python. Compared tofsum()
frommath
class it is more commonly used for smaller inputs. It Is also faster as it can be used directly used and does not convert the summation value intofloat
on each iteration unlikefloating-point sum
.For now only the
list
iterable is compatible with this function