Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C: Implement Dict pop #1568

Merged
merged 3 commits into from
Mar 10, 2023
Merged

C: Implement Dict pop #1568

merged 3 commits into from
Mar 10, 2023

Conversation

Smit-create
Copy link
Collaborator

No description provided.

@Smit-create Smit-create added the c Label for C language related changes label Mar 9, 2023
@Smit-create Smit-create marked this pull request as ready for review March 9, 2023 06:59
czgdp1807
czgdp1807 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do the benchmarking for this as well. Do it before you merge so that we know it runs at least, speeds up can be done later. https://gist.github.com/czgdp1807/e7f7b6ca52c57b16b27ec8d0259c6d4a#file-dict_bench_3-md

@Smit-create
Copy link
Collaborator Author

Benchmarks: https://gist.github.com/Smit-create/50e47b4e025126cf37033ec8f7ddadfd?permalink_comment_id=4497081#gistcomment-4497081

@Smit-create Smit-create merged commit 4704837 into lcompilers:main Mar 10, 2023
@Smit-create Smit-create deleted the dict_2 branch March 10, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
c Label for C language related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Smit-create @certik @czgdp1807