Added cbrt() and exp2() functions in Math module

[harshsingh-24]

Math Module enhancement:

• Added cbrt() or cube root function associated with Math module of LPython and it's associated integration tests
• Added exp2() or exponential of 2 function associated with Math module of LPython and it's associated integration tests

[harshsingh-24]

Can @Thirumalai-Shaktivel @Smit-create @certik check that why these integration tests are failing?

The following tests FAILED:
	 79 - test_math (Failed)
	114 - test_math_02 (Failed)

Expected Reason (according to me):

In CMakeLists.txt file these integration_tests are being executed on cpython-

RUN(NAME test_math           LABELS cpython llvm)
RUN(NAME test_math_02        LABELS cpython llvm)

I think, CPython does not support these functions?

[certik]

The error is:

  File "/home/runner/work/lpython/lpython/integration_tests/test_math_02.py", line 1, in <module>
    from math import (sin, cos, tan, pi, sqrt, log, log10, log2, erf, erfc, gamma,
ImportError: cannot import name 'cbrt' from 'math' (/usr/share/miniconda/envs/test/lib/python3.10/lib-dynload/math.cpython-310-x86_64-linux-gnu.so)

So I assume CPython 3.10 does not implement cbrt?

If so, we need some way to only run these tests with CPython 3.11.

[harshsingh-24]

The error is:

  File "/home/runner/work/lpython/lpython/integration_tests/test_math_02.py", line 1, in <module>
    from math import (sin, cos, tan, pi, sqrt, log, log10, log2, erf, erfc, gamma,
ImportError: cannot import name 'cbrt' from 'math' (/usr/share/miniconda/envs/test/lib/python3.10/lib-dynload/math.cpython-310-x86_64-linux-gnu.so)

So I assume CPython 3.10 does not implement cbrt?

If so, we need some way to only run these tests with CPython 3.11.

Yes. It was implemented in Python 3.11. So, how can we support tests with CPython 3.11? I am not sure whether CPython 3.11 supports it or not.

[certik]

Well, we might need to add this as an option in cmake to only run this in Python 3.11. For now, you can create a dedicated tests for this, and do not register them with cpython, only llvm. That way it works with LPython, but we skip testing it with CPython. We test it manually with CPython 3.11.

[harshsingh-24]

Well, we might need to add this as an option in cmake to only run this in Python 3.11. For now, you can create a dedicated tests for this, and do not register them with cpython, only llvm. That way it works with LPython, but we skip testing it with CPython. We test it manually with CPython 3.11.

Well, we might need to add this as an option in cmake to only run this in Python 3.11. For now, you can create a dedicated tests for this, and do not register them with cpython, only llvm. That way it works with LPython, but we skip testing it with CPython. We test it manually with CPython 3.11.

Well, we might need to add this as an option in cmake to only run this in Python 3.11. For now, you can create a dedicated tests for this, and do not register them with cpython, only llvm. That way it works with LPython, but we skip testing it with CPython. We test it manually with CPython 3.11.

@certik As I was discussing with @Thirumalai-Shaktivel and what you suggested earlier, I implemented a new backend that support Python 3.11 and updated the settings of those integration tests with Python 3.11. New Backend name is cpython_3_11. Can you please review that ? @Smit-create

[Smit-create]

Yeah, I'll need to update some tester files and CI to test this which I'll do after merging this PR. This looks good to me. I'll fix the tests once this is merged. Thanks @harshsingh-24

[certik]

This will disable this for current Python, which I would not do.

Split just the functionality that needs Python 3_11 and perhaps put into one file.

[Thirumalai-Shaktivel]

Yup, @harshsingh-24 create a separate file and add the cbrt and exp2 tests there and enable cpython_3_11 for it. Leave cpython for the rest of the tests.

[Thirumalai-Shaktivel]

We will not add this new option cpython_3_11 for now, see: #1594 (comment)

[Thirumalai-Shaktivel]

There is something that worries me, can we have two versions of python in the conda environment?

[Thirumalai-Shaktivel]

I see, we cannot have it: https://stackoverflow.com/a/67595797/15913193

#1594 (comment)
Well, we might need to add this as an option in cmake to only run this in Python 3.11. For now, you can create a dedicated tests for this, and do not register them with cpython, only llvm. That way it works with LPython, but we skip testing it with CPython. We test it manually with CPython 3.11.

@harshsingh-24 do one thing, we will split the cbrt and exp2 tests into a separate file and test only the LLVM. Maybe add a TODO to test with CPython

[harshsingh-24]

I have done all the changes as asked @certik @Thirumalai-Shaktivel. Can you please review it?

[Smit-create]

LGTM, will need to squash and merge.

[harshsingh-24]

I will do a git squash.

[Smit-create]

I will do a git squash.

No worries, we can do that while merging.

[Thirumalai-Shaktivel]

LGTM as well! Thank you

[czgdp1807]

Other than my comment rest looks okay.