Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for passing dict as function arguments #1683

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Support for passing dict as function arguments #1683

merged 1 commit into from
Apr 9, 2023

Conversation

harshsingh-24
Copy link
Contributor

  • Adds to Dict implementation design #983 checklist by giving support for passing dictionary as function arguments
  • Added Integration tests for the same including various combinations of dictionary return type and function args
  • Completes one of the TODOs: Dict implementation design #983 (comment) - Support passing dict as function arguments and return value of functions

@harshsingh-24
Copy link
Contributor Author

Can you please review? @certik @czgdp1807 @Thirumalai-Shaktivel

certik
certik approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, as long as @czgdp1807 agrees as well.

@certik certik requested a review from czgdp1807 April 8, 2023 18:08
@certik certik merged commit a1791ae into lcompilers:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshsingh-24 @certik @czgdp1807