Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle arguments of sizeof by distinguishing ttype and expr #1733

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Handle arguments of sizeof by distinguishing ttype and expr #1733

merged 2 commits into from
Apr 21, 2023

Conversation

czgdp1807
Copy link
Collaborator

Closes #1728

@czgdp1807 czgdp1807 marked this pull request as ready for review April 21, 2023 17:35
certik
certik approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, it works, thanks!

@certik certik enabled auto-merge April 21, 2023 17:45
@czgdp1807 czgdp1807 disabled auto-merge April 21, 2023 17:45
@czgdp1807 czgdp1807 merged commit 5148356 into lcompilers:main Apr 21, 2023
@czgdp1807
Copy link
Collaborator Author

Squashed and merge because first commit was sort of redundant.

@czgdp1807 czgdp1807 deleted the sizeof_02 branch April 21, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sizeof(x) doesn't work for external symbol x
2 participants
@czgdp1807 @certik