Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify: Add a check for order of Allocatable and Array #2069

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Verify: Add a check for order of Allocatable and Array #2069

merged 1 commit into from
Jun 30, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid commented Jun 30, 2023 •
edited
Loading

@Shaikh-Ubaid
Copy link
Collaborator Author

Shaikh-Ubaid commented Jun 30, 2023 •
edited
Loading

I just noticed this. It seems the issue is at LFortran and I raised the PR at LPython. (Sorry for inconvenience, I was scrolling through the issues at LPython, I did not realize when I changed my tab to LFortran.)

Shall I close this PR and submit at LFortran?

PS: Or I can submit another PR at LFortran after merging/completion of this PR.

@Shaikh-Ubaid Shaikh-Ubaid requested a review from certik June 30, 2023 21:25
@certik certik merged commit dde47f4 into lcompilers:main Jun 30, 2023
8 checks passed
@certik
Copy link
Contributor

certik commented Jun 30, 2023

Just send it to LFortran as well. Thanks for fixing it!

@Shaikh-Ubaid Shaikh-Ubaid deleted the asr_verify_arr_alloca branch June 30, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik Awaiting requested review from certik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify: add a check for order of Allocatable and Array
2 participants
@Shaikh-Ubaid @certik