Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement physical types for arrays #2079

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Implement physical types for arrays #2079

merged 2 commits into from
Jul 4, 2023

Conversation

czgdp1807
Copy link
Collaborator

Corresponding LFortran PR - lfortran/lfortran#1850

@czgdp1807 czgdp1807 force-pushed the phys_types branch 4 times, most recently from 748da91 to 0995818 Compare July 4, 2023 15:05
@certik
Copy link
Contributor

certik commented Jul 4, 2023

There is one error:

lpython: /home/runner/micromamba/envs/lp/include/llvm/IR/Instructions.h:1181: void llvm::ICmpInst::AssertOK(): Assertion `getOperand(0)->getType() == getOperand(1)->getType() && "Both operands to ICmp instruction are not of the same type!"' failed.

certik
certik approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, thank you @czgdp1807, great job!

@czgdp1807 czgdp1807 marked this pull request as ready for review July 4, 2023 16:43
@czgdp1807
Following changes have been made,
f921499 
1. Implemented physical types for arrays
2. Shifted LLVM type generation to LLVMUtils namespace
@czgdp1807
Updated reference tests
0b98e36
@czgdp1807 czgdp1807 enabled auto-merge July 4, 2023 16:52
@czgdp1807 czgdp1807 merged commit c472750 into lcompilers:main Jul 4, 2023
8 checks passed
@certik
Copy link
Contributor

certik commented Jul 4, 2023

Magnificent work!

@czgdp1807 czgdp1807 deleted the phys_types branch July 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgdp1807 @certik