Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set data structure #2122

Merged
merged 9 commits into from
Jul 15, 2023
Merged

Set data structure #2122

merged 9 commits into from
Jul 15, 2023

Conversation

kabra1110
Copy link
Collaborator

@kabra1110 kabra1110 commented Jul 8, 2023

Fixes #2024.
Introduces set data structure with linear-probing, and deepcopy, length functions.

@kabra1110 kabra1110 force-pushed the set_data_structure branch 3 times, most recently from bdb5364 to 1a92511 Compare July 11, 2023 02:40
@kabra1110
Copy link
Collaborator Author

kabra1110 commented Jul 11, 2023

I plan to add separate chaining and other functions in a separate PR.

Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for insertion and erase operation in sets.

Comment on lines +2757 to +2758
is_slot_empty = builder->CreateOr(is_slot_empty, builder->CreateICmpEQ(key_mask_value,
llvm::ConstantInt::get(llvm::Type::getInt8Ty(context), llvm::APInt(8, 3))));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to increase length of dict during write, if marker is tombstone.

@kabra1110
Copy link
Collaborator Author

This workflow error does not occur for me locally.

Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@czgdp1807 czgdp1807 marked this pull request as ready for review July 15, 2023 11:11
@czgdp1807 czgdp1807 enabled auto-merge (squash) July 15, 2023 11:50
@czgdp1807 czgdp1807 disabled auto-merge July 15, 2023 11:50
@czgdp1807 czgdp1807 merged commit 8d69c93 into lcompilers:main Jul 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support set types
2 participants