Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Check for warnings #2145

Merged
merged 4 commits into from
Jul 11, 2023
Merged

CI: Check for warnings #2145

merged 4 commits into from
Jul 11, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid commented Jul 10, 2023 •
edited
Loading

fixes #2139
fixes #1901

@Shaikh-Ubaid
Copy link
Collaborator Author

The debug build fails with the error ‘void free(void*)’ called on unallocated object ‘yyssa’ [-Werror=free-nonheap-object]. It works with clang on my system. It seems that this is a bug in gcc https://lists.gnu.org/archive/html/help-bison/2021-01/msg00025.html.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft July 10, 2023 22:46
@Shaikh-Ubaid
Copy link
Collaborator Author

The release build seems to work. Now we need to fix the debug build (#2145 (comment)).

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review July 11, 2023 11:11
@Shaikh-Ubaid Shaikh-Ubaid requested a review from certik July 11, 2023 11:12
@Shaikh-Ubaid
CI: Check debug build with -Werror
b2cd6d9 
Also use sccache in place of ccache. sccache seems to be faster
@Shaikh-Ubaid
CI: Check release build with -Werror
2779144
@Shaikh-Ubaid
Build: Suppress unused warning in parser.tab.cc
4091e43 
Ignore free-nonheap-object warning in debug mode
@Shaikh-Ubaid Shaikh-Ubaid force-pushed the ci_werror branch 2 times, most recently from 26dbe4a to 6682044 Compare July 11, 2023 14:54
@certik certik merged commit 32f7ec9 into lcompilers:main Jul 11, 2023
9 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the ci_werror branch July 11, 2023 17:32
@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request Jul 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New warning on macOS Build warnings on fresh clone
2 participants
@Shaikh-Ubaid @certik