Refactor: Several Improvements

[Shaikh-Ubaid]

No description provided.

[czgdp1807]

For a compiler like ours which is in fast pace development mode, I wouldn’t remove code which never gets triggered by the tests. Instead I would prefer adding tests which trigger that code. Its a time consuming process but that’s better than removing unused code because they might be having some important logic we might have written but missed to add tests for it (< 100% code coverage is very normal).

[Shaikh-Ubaid]

For a compiler like ours which is in fast pace development mode, I wouldn’t remove code which never gets triggered by the tests.

reference: Remove code that never gets triggered.

Actually, it is not about the tests. The current_module value is always nulltpr (it is assigned this value during its initialization and its value is never updated. Since current_module is always nulltptr, the if part would never be executed. Thus, I think the code itself is dead code.

[Shaikh-Ubaid]

Ready.

[certik]

Can you send a PR to LFortran for this change in libasr as well? Let's see if it breaks anything there.

[Shaikh-Ubaid]

Can you send a PR to LFortran for this change in libasr as well? Let's see if it breaks anything there.

Sure, please see lfortran/lfortran#1989.

[certik]

I think that this is fine, it works in LFortran.