LLVM: Support Unsigned Int in visit_Variable

[Smit-create]

Fixes #2170

[certik]

This is fine, but after merging let's add tests for all unsigned kinds as well as checking that the value is present in the variable correctly.

What exactly was the problem --- that this is using global variables?

[Shaikh-Ubaid]

Please see #2170 (comment). I think the else if condition added in this PR would never be executed since the first if in the visit_Variable() would be executed for Integers as well as UnsingedIntegers. Thus, it seems the else if condition is more like a dead code.

lpython/src/libasr/codegen/asr_to_llvm.cpp

Lines 2356 to 2378 in ea9715b

	if (x.m_type->type == ASR::ttypeType::Integer
	|| x.m_type->type == ASR::ttypeType::UnsignedInteger) {
	int a_kind = ASRUtils::extract_kind_from_ttype_t(x.m_type);
	llvm::Type *type;
	int init_value_bits = 8*a_kind;
	type = llvm_utils->getIntType(a_kind);
	llvm::Constant *ptr = module->getOrInsertGlobal(x.m_name,
	type);
	if (!external) {
	if (ASRUtils::is_array(x.m_type)) {
	throw CodeGenError("Arrays are not supported by visit_Variable");
	}
	if (init_value) {
	module->getNamedGlobal(x.m_name)->setInitializer(
	init_value);
	} else {
	module->getNamedGlobal(x.m_name)->setInitializer(
	llvm::ConstantInt::get(context,
	llvm::APInt(init_value_bits, 0)));
	}
	}
	llvm_symtab[h] = ptr;
	} else if (x.m_type->type == ASR::ttypeType::UnsignedInteger) {

[Shaikh-Ubaid]

This is fine, but after merging let's add tests for all unsigned kinds as well as checking that the value is present in the variable correctly.

Yes, I tested different unsigned kinds in https://github.com/lcompilers/lpython/pull/2164/files#diff-b6a08444f0697e1ea781c919bcdf3b29eba7b542bddef56ce0125f3c2997c973.

[Shaikh-Ubaid]

If in case we update the changes in this PR, I suggest we add an assert in this test case (and also possibly a print statement before the assert).