CI: make bash fail on errors #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaikh-Ubaid
force-pushed
the
ci_make_fail
branch
from
d108db8
to
19143b3
Compare
|
We need to rebase this PR after merging/completion of #2196. |
Yes , otherwise the PR looks good . I can see we catch the errors which were being ignored prior to this ! |
|
I think I did something similar for LFortran as well. Thanks for catching it! |
Errors were ignored before.
|
The SymPy test correctly failed (https://github.com/lcompilers/lpython/actions/runs/5608325831/job/15194656881?pr=2194), so let's see if it passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors were ignored before.
fixes #2195