-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set separate chaining #2198
Set separate chaining #2198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping me whenever this is ready for review.
src/libasr/codegen/llvm_utils.cpp
Outdated
} else { | ||
set_api = set_api_lp; | ||
} | ||
// set_api = set_api_lp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will benchmark separate chaining, and modify this accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this in the gist. Separate Chaining does not appear to provide significant benefits.
@kabra1110 There is one error in debug build CI. Could you please look into that? |
I had tried looking it earlier, but this does not appear locally, and the error also doesn't seem to be correct
The function is @interface
@overload
def complex(x: f64, y: f64) -> c64:
"""
Return a complex number with the given real and imaginary parts.
"""
return c64(x) + c64(y)*1j This appears OK |
259046d
to
84e2117
Compare
84e2117
to
94aa2d0
Compare
@czgdp1807 Looks like this is good to merge. I have made Linear Probing as default for sets, but haven't removed |
Awesome, great job! |
Adds separate chaining for sets.