Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Provide release flags, exclude -march=native #2212

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

I think we just need to lower the optimization options, perhaps keep -O3, but remove -march=native or something like that.

towards #2162 (comment)

@Shaikh-Ubaid
Copy link
Collaborator Author

I am unsure if the changes in this PR are the perfect fix. This seems to be more of an experimental PR. I think we can later try other steps/approaches if the failure in Release build is still experienced post merging of this PR.

Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So -O3 optimisations weren't applied in the release build before this PR?

@Shaikh-Ubaid
Copy link
Collaborator Author

So -O3 optimisations weren't applied in the release build before this PR?

I think they were being applied.

set(CMAKE_CXX_FLAGS_RELEASE_INIT "${common} -O3 -march=native -funroll-loops -DNDEBUG")

In this PR, I just excluded the -march=native flag.

@certik
Copy link
Contributor

certik commented Jul 26, 2023

Yes, let's try this and see.

@certik certik merged commit c1a613b into lcompilers:main Jul 26, 2023
9 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the ci_fix_release_often_failure branch July 26, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants