Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASR: Support chained CompareOp #2213

Merged
merged 6 commits into from
Jul 29, 2023
Merged

ASR: Support chained CompareOp #2213

merged 6 commits into from
Jul 29, 2023

Conversation

Smit-create
Copy link
Collaborator

Fixes #2131

@Smit-create Smit-create requested a review from certik July 27, 2023 07:04
@Smit-create Smit-create marked this pull request as ready for review July 27, 2023 14:29
czgdp1807
czgdp1807 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM already works but C needed some changes. That's surprising. Approving it anyways.

@Smit-create Smit-create requested a review from certik July 28, 2023 05:04
certik
certik approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good.

@certik certik merged commit 1b5bafd into lcompilers:main Jul 29, 2023
9 checks passed
@Smit-create Smit-create deleted the i-2131 branch July 29, 2023 04:38
@certik certik mentioned this pull request Jul 30, 2023
Closed
This was referenced Jul 30, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing multiadic Boolean ==
3 participants
@Smit-create @certik @czgdp1807