Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter names for global_initializer() and global_statements() #2246

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid commented Aug 2, 2023

The existing names seem very long. They surpass the node width in the ASR Visualization.

Main Branch:
Screenshot 2023-08-02 at 6 20 15 PM

PR Branch:
Screenshot 2023-08-02 at 6 22 42 PM

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine.

@Shaikh-Ubaid Shaikh-Ubaid merged commit e39f04f into lcompilers:main Aug 2, 2023
9 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the shorter_names branch August 25, 2023 18:40
@Shaikh-Ubaid Shaikh-Ubaid restored the shorter_names branch August 25, 2023 18:40
@Shaikh-Ubaid Shaikh-Ubaid deleted the shorter_names branch August 25, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants