CI: Test integration_tests with Python 3.9, 3.10 and 3.11 #2298
Conversation
|
It seems |
|
I have an idea. Why not to test |
Shaikh-Ubaid
force-pushed
the
ci_python_3_9
branch
from
107355b
to
e2b691f
Compare
Shaikh-Ubaid
changed the title
|
We currently test both |
| @@ -623,7 +635,7 @@ RUN(NAME bindpy_01 LABELS cpython c_py ENABLE_CPYTHON NOFAST COPY_TO_B | |||
| RUN(NAME bindpy_02 LABELS cpython c_py LINK_NUMPY COPY_TO_BIN bindpy_02_module.py) | |||
| RUN(NAME bindpy_03 LABELS cpython c_py LINK_NUMPY NOFAST COPY_TO_BIN bindpy_03_module.py) | |||
| RUN(NAME bindpy_04 LABELS cpython c_py LINK_NUMPY NOFAST COPY_TO_BIN bindpy_04_module.py) | |||
| RUN(NAME bindpy_05 LABELS llvm_py c_py ENABLE_CPYTHON COPY_TO_BIN bindpy_05_module.py) | |||
| RUN(NAME bindpy_05 LABELS llvm_py c_py ENABLE_CPYTHON COPY_TO_BIN bindpy_05_module.py REQ_PY_VER 3.10) | |||
There was a problem hiding this comment.
This test seems to fail with Python 3.9. For the moment, I marked it as REQ_PY_VER 3.10. I will tackle the failure with Python 3.9 in a future PR.
First part works with Python >= 3.9 Second part works with Python >= 3.10
This helps us to obtain the Python version
Shaikh-Ubaid
force-pushed
the
ci_python_3_9
branch
from
e2b691f
to
c5ef1af
Compare
|
From #1827 (comment),
We now explicitly test all the three |
| string(REGEX REPLACE "([0-9]+)\\.([0-9]+)" "\\1" REQ_PY_MAJOR_VERSION "${RUN_REQ_PY_VER}") | ||
| string(REGEX REPLACE "([0-9]+)\\.([0-9]+)" "\\2" REQ_PY_MINOR_VERSION "${RUN_REQ_PY_VER}") | ||
|
|
||
| if (PY_MINOR_VERSION LESS REQ_PY_MINOR_VERSION) |
There was a problem hiding this comment.
This compares only the Python minor versions for now. We might need to consider Python major versions when Python 4.0.0 is released, but I guess there might probably be some time for it.
|
The CI is green. This is ready! |
fixes #1827 (comment)