Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[numpy] add fix #2330

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[numpy] add fix #2330

merged 1 commit into from
Sep 20, 2023

Conversation

khushi-411
Copy link
Contributor

Follows #959

@khushi-411 khushi-411 marked this pull request as ready for review September 20, 2023 09:08
certik
certik approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this looks good. We can later refactor how we handle all these rounding functions in ASR, including names (I didn't know what "Fix" should do, had to look it up: numpy.fix), but for now I think this works.

@certik certik merged commit 0d9fff9 into lcompilers:main Sep 20, 2023
12 checks passed
@khushi-411 khushi-411 deleted the lp_fix branch September 20, 2023 17:43
@nikabot nikabot mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khushi-411 @certik