Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented symbolic constant E #2387

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Implemented symbolic constant E #2387

merged 3 commits into from
Oct 24, 2023

Conversation

anutosh491
Copy link
Collaborator

I've made this pull request as a helping PR for #2386

@anutosh491
Copy link
Collaborator Author

We've tested out the constant pi enough, E would behave just as same as pi. Not sure if I should add some test for it. All operations that could be done on pi can be replicated for E, so all tests that pass for expressions involving pi would also work for E

@certik
Copy link
Contributor

certik commented Oct 23, 2023

Definitely add a test for E. That's to ensure that everything actually works and that it will not get broken in the future.

@anutosh491
Copy link
Collaborator Author

Done. I've added a minimalistic test function as of now which checks overall use of E.

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Oct 24, 2023

Not really sure why the LPython CI / LPython CI (3.10, ubuntu-latest) test fails . I am not able to replicate it locally !

EDIT: Re-running the CI makes it pass.

@certik certik merged commit 974f1dc into lcompilers:main Oct 24, 2023
13 checks passed
@certik
Copy link
Contributor

certik commented Oct 24, 2023

Thanks! What was the failure at the CI?

@anutosh491
Copy link
Collaborator Author

I think so 1 test (test_complex_02.py) failed abruptly with the C backend with the fast flag. Thirumalai told me that he has seen the failure before and it occurs sometimes in the CI. He adviced me to re-run the tests!

@certik
Copy link
Contributor

certik commented Oct 24, 2023

It's a flaky test then. Can you report the error into an issue with a log of the failure? We need to keep track of this, so that we can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants