-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Out[S] #2419
Added support for Out[S] #2419
Conversation
I think the |
So currently we can do something like
But through the llvm backend we would still be stuck as we had discussed previously (#2411 (comment))
|
I think this is good. Can you please add a test? Also, can you submit just the libasr change to lfortran, to ensure everything works there? |
Done. |
We should also discuss as to how we would address comment (#2411 (comment)) because if you think about it, the function definition for
Trying to replicate something like the following
Which means we need to return a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine. Can you also add a test for Out[S]
explicitly? Right now it is only tested implicitly via the subroutine_from_function.
Sure. |
Thanks to the well framed
subroutine_from_function
pass. Now we can return symbolic objects through a cummulative result of thesubroutine_from_function
andsymbolic
pass.