-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor string attributes and add constant string implementations #2524
Conversation
… tests to its appropriate location
… tests to its appropriate location
Not sure what is going on, but somehow the CI shows an error:
|
I am not sure what is going on either, as there are no changes in |
I tried building and running the tests locally, but I could not replicate the issue. I am using Ubuntu 22.04, so I am unsure why the CI is failing. @interface
@overload
def complex(x: f64) -> c64:
return c64(x) + c64(0)*1j This is the function where there is an error. x is declared, so I do not know why there is a bug. |
@certik Please take a look at this when you can, I am not sure how to fix this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. I don't know why it failed. We'll watch the CI for this error.
istitle
andisalpha
were implemented only for variables and not constant strings, so I added implementations and tests.test_str_attributes
along with all the other string methods.istitle
istitle
andisalpha
logic inpython_ast_to_asr.cpp
to follow the otheris
methods.