Fixes #2490: Adds unescaping \f and the correct implementation of isspace() string method.
#2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all whitespace characters.
kmr-srbh
changed the title
\f and adds the correct implementation of the isspace() string method.\f and adds the correct implementation of the isspace() string method.
kmr-srbh
changed the title
\f and adds the correct implementation of the isspace() string method.\f and the correct implementation of isspace() string method.
|
What is the status of this PR? |
It is ready for review @Thirumalai-Shaktivel. |
| @@ -974,16 +1103,18 @@ def _lpython_str_isupper(s: str) -> bool: | |||
| return False | |||
| return is_cased_present | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Remove all the formatting changes and you can submit a new PR for it.
| # If none of the characters match, we have atleast one character which is not | ||
| # a whitespace, so we return `False`. | ||
| if ( | ||
| ch_ord != 9 |
There was a problem hiding this comment.
Thanks for handling all the cases, but it doesn't seems to be more readable.
By readable what I meant is, I have to manually check what 9 is, and confirm that \t is handled.
Was there any issue with previous changes?
Also, instead of this long condition check, why not keep the strings in list and have a single condition check?
| x += "\f"; | ||
| idx++; | ||
| } | ||
| else if (s[idx] == '\\' && s[idx + 1] == '\\') { |
There was a problem hiding this comment.
Please remove the formatting changes.
|
Please mark this PR ready for review once it is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
#2490 gave wrong output due to the incorrect handling of the escape sequence '\f'. Escaping the sequence was handled, but unescaping was missed. This led to the string
" \t\n\v\f\r"being transformed to" \t\n\v\\f\r"in the AST. Note the extra "\" after "v".Hence, the answer in #2490 was thus 'not actually' wrong as non-whitespace and lowercase characters did exist. Fixes #2490
Improvement
Though the error in the above case was due to incorrect string handling, the
isspace()method was actually not implemented correctly. The definition of a 'whitespace' character is actually broad. The Python interpreter checks for all of them in it's implementation of the method. I incorporated checking for those characters.A huge shout-out to @advikkabra for the clever testing. 🎉
Note
The Black formatter has automatically formatted the Python file I worked on. Please note that only change I made was the implementation of the
isspace()method.Last but not the least, I thoroughly enjoyed working on the issue. 😃