Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cmake version for windows #2562

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

Kishan-Ved
Copy link
Contributor

@Kishan-Ved Kishan-Ved commented Feb 28, 2024

Fixes: #2561

For most of the recent PRs, the windows CI fails.

CMake Error at C:/Program Files/CMake/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-3.28/Modules/FindZLIB.cmake:199 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/FindStaticZLIB.cmake:7 (find_package)
  CMakeLists.txt:116 (find_package)


-- Configuring incomplete, errors occurred!

The error is related to the default CMake installed on Windows. I have updated windows cmake version to cmake=3.21.1 in the CI.yml file.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@certik certik merged commit 68774de into lcompilers:main Feb 28, 2024
13 checks passed
@Kishan-Ved Kishan-Ved mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI fails due to "Could NOT find ZLIB" cmake
2 participants