Fixing symbolic pass according to error caught in LFortran #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HarshitaKalani I think once this PR is merged and the the sync from lpython to lfortran is completed, you can go ahead and enable the symbolic pass back in lfortran. Thanks for bringing this bug to my notice. |
|
@certik I think this would do. If you see any vulnerabilites here, I shall address it in subsequent PRs. Merging ! |
Agent-Hellboy
pushed a commit
to Agent-Hellboy/lpython
that referenced
this pull request
Mar 5, 2024
hankluo6
pushed a commit
to hankluo6/lpython
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2553
Anytime before we make a call to
process_attributes, it is essential that we check whether the logical intrinsic function is symbolic based, and that is being done in this PR through a bool check.