Prevent calling abort
while handling the SIGABRT
signal
#2626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We register
loc_abort_callback_print_stack
as a callback on theSIGABRT
signal andloc_segfault_callback_print_stack
on theSIGSEGV
signal. (reference: https://github.com/lcompilers/lpython/blob/main/src/libasr/stacktrace.cpp#L530-L531)Tracing the flow of function calls:
loc_abort_callback_print_stack
andloc_segfault_callback_print_stack
callsget_stacktrace
(reference: https://github.com/lcompilers/lpython/blob/main/src/libasr/stacktrace.cpp#L524 & https://github.com/lcompilers/lpython/blob/main/src/libasr/stacktrace.cpp#L516)get_stacktrace
callsget_local_addresses
(reference: https://github.com/lcompilers/lpython/blob/main/src/libasr/stacktrace.cpp#L537)get_local_addresses
callsget_local_address
(reference: https://github.com/lcompilers/lpython/blob/main/src/libasr/stacktrace.cpp#L561)get_local_address
callsabort
. (reference: https://github.com/lcompilers/lpython/blob/main/src/libasr/stacktrace.cpp#L142)So while handling
SIGABRT
we end up regeneratingSIGABRT
and the cycle repeats. To prevent this, I have changed theabort()
toexit(1)
to immediately exit.I observed this while working on #2564 and #2595.