Removed error banner from tests (#2631) #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaikh-Ubaid
force-pushed
the
error_banner_fix
branch
from
4bf88b9
to
d47e9f1
Compare
Shaikh-Ubaid
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses Issue #2631, which concerns the removal of the error banner from tests. The issue has been resolved by introducing the
--no-error-bannerflag in the extra_args parameter of therun_testfunction. This flag effectively disables the display of unwanted text during test execution.Changes Made:
--no-error-bannerflag to disable error banner in tests.run_testfunction to include the extra_args parameter with the--no-error-bannerflag.Testing:
I've tested these changes locally to ensure that the error banner is properly disabled during test execution. All existing tests continue to pass without any issues.