-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement visitor: NamedExpr
#37
Conversation
I guess just rerunning the tests does not fix them (apparently the CI tests are not running on a merge commit?). But rebasing on top of the latest main should fix this, so I did that. |
Ok, so the CI failure is real, the C++ backend does not support this yet. I think we have to separate the C++ backend tests from new improvements in ASR. |
I'm working on it. |
I pushed in the fix, now it should work. |
Awesome, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it works now. After the CI passes, you can merge it.
Reference code:
ASR: