Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test error messages #412

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Test error messages #412

merged 3 commits into from
Apr 22, 2022

Conversation

Smit-create
Copy link
Collaborator

Comment on lines +4 to +5
6 | a.append(4, 5)
| ^^^^^^^^^^^^^^
Copy link
Contributor

@certik certik Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we can improve these messages, here is an idea:

Suggested change
6 | a.append(4, 5)
| ^^^^^^^^^^^^^^
6 | a.append(4, 5)
| ^^^^^^ ┬ ┬
| │ └──┴── two arguments provided
| │
| expected one argument

This is how it looks like in a terminal (without colors):

Screen Shot 2022-04-22 at 7 46 34 AM

And of course there would be colors.

I posted this comment at #398 (comment) so that we don't forget.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, thank you!

@certik certik merged commit be79690 into lcompilers:main Apr 22, 2022
@Smit-create Smit-create deleted the err-msg branch April 22, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants