Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Dict Insert in ASR #432

Merged
merged 5 commits into from
Apr 30, 2022
Merged

Implement Dict Insert in ASR #432

merged 5 commits into from
Apr 30, 2022

Conversation

Smit-create
Copy link
Collaborator

@Smit-create Smit-create requested a review from certik April 29, 2022 13:12
namannimmo10
namannimmo10 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@namannimmo10 namannimmo10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great otherwise. thanks!

@Smit-create Smit-create added the ready for review PRs that are ready for review label Apr 30, 2022
certik
certik approved these changes Apr 30, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot for this!

@certik certik merged commit 8784917 into lcompilers:main Apr 30, 2022
@Smit-create Smit-create deleted the dict_insert branch May 1, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@namannimmo10 namannimmo10 namannimmo10 approved these changes

Assignees
No one assigned
Labels
ready for review PRs that are ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Smit-create @certik @namannimmo10