-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle printing of logical types in the LLVM backend #504
Conversation
I reviewed. Thanks for requesting review. |
I think this is already fixed in
Gives,
Handling booleans as integers in the LLVM backend is good in my opinion because ASR is language independent and the LLVM backend is used for different frontend languages, we might have some confits in printing booleans explicitly like "True" in some front-end languages and "true" in some others. |
The issue is that LPython should print it like CPython does, and LFortran like other Fortran compilers do. But this can be easily configurable, say as an option to |
60a4dcc
to
8af9d35
Compare
I am sorry for the long delay in addressing the comments. Note that this is ready for the Python frontend for now. We have to think of a way to make this work for LFortran, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works. Thanks!
fixes #322