Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test out of tree #634

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Test out of tree #634

merged 6 commits into from
Jun 20, 2022

Conversation

certik
Copy link
Contributor

@certik certik commented Jun 19, 2022

No description provided.

@certik certik mentioned this pull request Jun 19, 2022
Closed
@czgdp1807
Copy link
Collaborator

Thanks @certik and @Smit-create for taking the initiative on this. ❤️🚀. Its an important one.

@czgdp1807 czgdp1807 added CI tests Testing related changes labels Jun 19, 2022
@certik
Copy link
Contributor Author

certik commented Jun 19, 2022

@Smit-create go ahead and try to finish it, I have to work on other things.

@Smit-create
Copy link
Collaborator

Ah, windows still fail. Mac and Linux are happy. May be some issues with <filesystem>?

@certik
Copy link
Contributor Author

certik commented Jun 20, 2022

The windows error is:

D:\a\lpython\lpython\lpython-0.2.0-1053-g577343ea8\src\lpython\semantics\python_ast_to_asr.cpp(3607): error C2664: 'LFortran::Result<LFortran::ASR::asr_t *> LFortran::LPython::symbol_table_visitor(Allocator &,const LFortran::LPython::AST::Module_t &,LFortran::diag::Diagnostics &,bool,std::map<int,LFortran::ASR::symbol_t *,std::less<int>,std::allocator<std::pair<const int,LFortran::ASR::symbol_t *>>> &,std::string)': cannot convert argument 6 from 'std::filesystem::path' to 'std::string'

certik
certik commented Jun 20, 2022
View reviewed changes
src/lpython/semantics/python_ast_to_asr.cpp
{
std::map<int, ASR::symbol_t*> ast_overload;

std::filesystem::path fp = file_path;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is probably right here.

@Smit-create Smit-create marked this pull request as ready for review June 20, 2022 08:35
@czgdp1807
Copy link
Collaborator

Works locally as expected.

@Smit-create
Copy link
Collaborator

@certik Please take a look.

@certik
Copy link
Contributor Author

certik commented Jun 20, 2022

It seems to work for me, so I am going to go ahead and merge this. Thanks!

@certik certik merged commit b55113d into lcompilers:main Jun 20, 2022
@certik certik deleted the test_out_of_tree branch June 20, 2022 11:46
@certik
Copy link
Contributor Author

certik commented Jun 20, 2022

This PR breaks the build on gcc 7.5.0.

@Smit-create Smit-create mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
CI tests Testing related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@certik @czgdp1807 @Smit-create