Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing initialisation at declaration issues #642

Merged
merged 11 commits into from
Jun 20, 2022
Merged

Fixing initialisation at declaration issues #642

merged 11 commits into from
Jun 20, 2022

Conversation

czgdp1807
Copy link
Collaborator

@czgdp1807 czgdp1807 added the asr ASR related changes label Jun 20, 2022
@czgdp1807 czgdp1807 marked this pull request as draft June 20, 2022 06:25
certik
certik approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@czgdp1807
Copy link
Collaborator Author

Going to push some more commits.

@czgdp1807 czgdp1807 added c Label for C language related changes llvm LLVM related changes labels Jun 20, 2022
@czgdp1807 czgdp1807 marked this pull request as ready for review June 20, 2022 11:02
@czgdp1807 czgdp1807 requested a review from certik June 20, 2022 11:02
certik
certik approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, thanks!

@certik certik merged commit 998e8ba into lcompilers:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
asr ASR related changes c Label for C language related changes llvm LLVM related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgdp1807 @certik