Mean, Geometric Mean & Harmonic mean Functions implemented in Statistics.py module #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@certik @czgdp1807 @namannimmo10 please review |
| @@ -176,6 +176,7 @@ RUN(NAME test_max_min LABELS cpython llvm) | |||
| RUN(NAME test_integer_bitnot LABELS cpython llvm) | |||
| RUN(NAME test_unary_minus LABELS cpython llvm) | |||
| RUN(NAME test_unary_plus LABELS cpython llvm) | |||
| RUN(NAME test_statistics LABELS cpython) | |||
There was a problem hiding this comment.
llvm tests weren't passing, I think it had something to do with list implementation in the backend
There was a problem hiding this comment.
Was getting the following error:
semantic error: Arguments do not match for any generic procedure, mean
--> /home/madhav/lpython/integration_tests/test_statistics.py:11:9
|
11 | j = mean(b)
| ^^^^^^^
certik
approved these changes
Jul 19, 2022
|
I think that this is fine. Can you please isolate the bugs that prevent LPython to compile this, and report them as issues? Let's get them fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.